Feature/ns to gw #1071
Draft
Feature/ns to gw #1071
+12,011
−5,934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation error messages namespace to gateway
Cypress/ns to gw regression tests
/devportal and /manager redirects
…ces-portal into feature/ns-to-gw
Feature approve own request
…ces-portal into feature/ns-to-gw
display name min 3 chars
rustyjux
reviewed
Aug 8, 2024
| @@ -165,7 +165,7 @@ export class NamespaceController extends Controller { | |||
| result.errors.forEach((err: any, ind: number) => { | |||
| errors[`d${ind}`] = { message: err.message }; | |||
| }); | |||
| throw new ValidateError(errors, 'Unable to create namespace'); | |||
| throw new ValidateError(errors, 'Unable to create gateway'); | |||
There was a problem hiding this comment.
Revert? (since in v2 we still say namespace everywhere else, including the routing)
rustyjux
reviewed
Aug 8, 2024
| @@ -201,7 +201,7 @@ export class NamespaceController extends Controller { | |||
| result.errors.forEach((err: any, ind: number) => { | |||
| errors[`d${ind}`] = { message: err.message }; | |||
| }); | |||
| throw new ValidateError(errors, 'Unable to delete namespace'); | |||
| throw new ValidateError(errors, 'Unable to delete gateway'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Resolves:
🚀 Feature branch deployment: https://api-services-portal-feature-ns-to-gw.apps.silver.devops.gov.bc.ca
🚀 Feature branch deployment: https://api-services-portal-feature-ns-to-gw.apps.silver.devops.gov.bc.ca